http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <[email protected]> --- Hi Julian, I feel like this would have been a bit better split up into 2 separate bugs/features. Tried a few things and have some first feedback from code review and tests: Bug 13392: Add suggestions.ordereddate and suggestions.orderedby 1) I am not sure about adding ordereddate and orderedby as those seem duplicating the information we can get from aqorders.entrydate and aqbasket.authorisedby. Bug 13392: New statistics assistant for suggestions 1) The new tests don't give any information when run, please add a description. 2) Using the Koha:I18N is an option now, but I think we haven't created the po file that is needed for it yet. Those strings appear already multiple times in the templates, so the translators have to make sure to translate them the same as everywhere else. I feel it might be easier if we moved them to the template. But more important, the custom suggestion statuses are not supported by the new wizard (authorized value SUGGEST_STATUS) 3) For MARC21 the publicationyear is saved in the copyrightdate column in the database. Please change so that copyrightdate is used in the SQL query for MARC21 databases. 4) The bsort1 and bsort2 fields can be freetext if there are no entries in the authorised value categories - maybe show an input field in that case? 5) Please rename branch to library on the suggestion form. And maybe just "Reason" instead of "Reject reason"? The reasons can also be positive. In testing this I had difficulties with getting a suggestion into the ORDERED status with and without the patches - can you check if that works for you? The new database fields stayed empty too :( -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
