http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679
--- Comment #210 from Jonathan Druart <[email protected]> --- (In reply to M. Tompsett from comment #209) > Comment on attachment 34197 [details] [review] > Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm > > Review of attachment 34197 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/TmplTokenType.pm > @@ +90,5 @@ > > +sub DECL { $_decl } > > +sub PI { $_pi } > > +sub DIRECTIVE { $_directive } > > +sub COMMENT { $_comment } > > +sub UNKNOWN { $_unknown } > > DECL, PI, COMMENT, and UNKNOWN seem to have no easy way to test them. > Consider improving testing coverage for TmplTokenType explicitly. Hello Mark, The patch did not modify the contain of these subroutines, I don't think tests should be mandatory here. And I don't have any ideas how I could test them :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
