http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #7 from Colin Campbell <[email protected]> --- (In reply to Jonathan Druart from comment #2) > Created attachment 35406 [details] [review] > Bug 13601: Make dt_from_string not using DateTime::Format::DateParse > > For a couple of reasons, dt_from_string should not use > DateTime::Format::DateParse: > 1/ It does not manage date < 1900, certainly caused by l.47 of this > module: > $p{ year } = $year ? $year + 1900 : DateTime->now->year; > > 2/ It considers 31/01/2015 as a valid us date, which is not. > > Test plan: > 1/ Verify that > prove t/DateUtils.t > returns green > 2/ Play with dates in Koha (yes I know, it's vague...) > 3/ Try to find a regression with dates > 4/ Create a date with year <= 1900 and confirm it works > > QA comment: > Why the sql format switch was: > - $date_string =~ > -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/; > > From where a date like "yyyymmdd hhmmss" can come? C4::Dates supported the format so DateUtils had to accept it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
