http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602
--- Comment #11 from Jonathan Druart <[email protected]> --- Comment on attachment 35651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35651 [PASSED QA] Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences Review of attachment 35651: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13602&attachment=35651) ----------------------------------------------------------------- ::: members/memberentry.pl @@ +329,5 @@ > } > } > + # Check if the userid is unique. Userid might not always be present in the > edited values list when editing certain sub-forms, so we need to dig for it a > bit. > + my $userid = $newdata{'userid'}; > + $userid = $borrower_data->{userid} unless $userid; #Get the userid > straight from the DB In my opinion, my $userid = $newdata{userid} ? $newdata{userid} : $borrower_data->{userid}; or my $userid = $newdata{userid}; $userid ||= $borrower_data->{userid}; Would have been more readable. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
