http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #39 from Robin Sheat <[email protected]> --- (In reply to Jonathan Druart from comment #38) > Thanks Robin for the wiki page. > I have quickly tested this morning, to confirm the search works. > Just some quick notes: > - The indexation should commit every 1k biblio (minimum), the commit is a > slow op indeed. Yeah. The commit rate I'm defining is currently actually not useful as Catmandu has its own buffering and committing system. I think that's changeable though. I also think the whole indexing process can be optimised a fair bit. I just haven't looked into it yet. > - You have removed the use of search/results.tt in your last commit, is it > intended? I am pretty sure it's not a good idea to use the same template for > ES and Zebra, but maybe it's temporary. Hmm? I'm not totally sure what you mean here. I am totally deliberately using the same template to show ES results as also shows zebra results, that's by design. Any other way would require copy-pasting 99% of the template, when there's already a perfectly good one that shows search results. I'm also trying to make a bit of an abstract search layer thing, not totally perfectly, to make it easier to work with this sort of thing in the future (very much based off your solr stuff in that respect.) > Note that there are encoding errors in facets (and in the table results > also), the "Show more" link appears even if only 1 entry is displayed. Yep, definitely. There'll be a lot of things like that that just need to be polished. > I only get 2 facets: authors and itemtype. MARC21 or UNIMARC? You should get more, though I haven't looked at that for a while. For example, http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-search.pl?q=chicken give availability, item types, authors and topics. But the facet stuff as a whole will need more work, I mostly got it to the point where it works at all and then moved on. > Do you plan to rebase your work against master? It would be great to see > these patches on top of bug 11944. Yes, I do. I'm just a little afraid to as I know it'll conflict with many, many things. One day soon I'll suck it up and do it though. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
