http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

--- Comment #62 from M. Tompsett <[email protected]> ---
Comment on attachment 28360
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28360
Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries

Review of attachment 28360:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=28360)
-----------------------------------------------------------------

::: C4/Acquisition.pm
@@ +2414,5 @@
> +        my @branches = GetIndependentGroupModificationRights();
> +        $query .=
> +          " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( "
> +          . join( ',', ('?') x @branches ) . " ) ) ";
> +        push( @query_params, @branches );

2416 has a ? in addition to the join'd ones on 2417. This leads to an off by
one error. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to