http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #97 from Julian Maurice <[email protected]> --- (In reply to M. de Rooy from comment #86) > QA Comment: > > Passes qa tools. > > Verified Basketgroups.t. > This test does not contain any testnames in the calls to ok, is, etc. It is > encouraged to do so. Could you please add? Added by attachment 35755 > > Question: Do we still need the column closed, if you add a closeddate in > aqbasketgroups? > Do we create redundancy? And what about confusion like: Hey closed=0 but > there is a closeddate? > Please convince me that we should have both columns. We probably don't need both. Removed in attachment 35756 > > [PATCH 6/7] Bug 11708: Remove the amount columns > Commit message says only: This should be managed in a specific bug. > Please explain. The amount columns show wrong amounts (comment 45) so they are removed until a specific bug addresses this issue. If you think it's better to keep them, we can remove this patch I think. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
