http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Jonathan Druart <[email protected]> --- (In reply to paxed from comment #68) > (In reply to Kyle M Hall from comment #67) > > Created attachment 35846 [details] [review] [review] > > Just wondering if http:// vs https:// matters for this: > > + // This is way faster than substring > + if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' && > sound.charAt(6) == '/' ) ) { Good catch, maybe a regex is much more appropriate here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
