http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211
--- Comment #47 from Jesse Weaver <[email protected]> --- (In reply to Magnus Enger from comment #46) > I have provided a followup in attachment 34040 [details] [review] that > should take care of most of the problems I have found. This probably needs a > signoff. If this followup meets with approval, I think there is still one > question that needs to be addressed: > > Jonatahan, comment 5: "Could you explain why you changed "holiday" with > "event" and you removed "Holiday exception" please?" > > Me, comment 32: "4. With this patch applied you now get to choose if the > library is open or closed when you add an event. As far as I can tell, the > special_holidays.isexception field is used to record open/closed. But the > description for this field is "is this a holiday exception to a repeatable > holiday (1 for yes, 0 for no)". Is open/closed a sensible use/interpretation > of this field? I am not sure of the usage, so I am only raising this as a > question." > > To rephrase: Does the repurposing of special_holidays.isexception to store > open/closed make sense, and does it mean we loose some functionality > connected to making exceptions from repeating holidays? RE: comment 5: I used event instead of holiday because you can now record that a given day is open or closed, seperately of the precedence order of specific day > day/month > weekday. RE: comment 32: I will at least cite lines 219-220 of Koha/Calendar.pm to argue for this patch's interpretation of isexception == open: # exceptions are not holidays return 0; -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
