http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #64 from Katrin Fischer <[email protected]> --- Wow, first comment here from me was over a year ago :( As this is a bigger feature with a longer history, I will leave some longer testing notes for reference: Automated Testing: - OK - QA script passes on current 5 patches - OK - Unit tests, especially all in t/db_dependent/Serial* pass Code Review: - OK - New sub GetPreviousSerialid has unit tests and is used to get the last arrived serial item. - OK - Database changes in updatedatabase and kohastructure are the same. - (1) serials-edit.pl: Patch adds SQL to the .pl script - please move this out of the pl script. - (2) System preference description currently reads: previous serial automatically available when collecting a new serial. Please note that the item-level_itypes syspref must be set to specific item. -- s/collecting/receiving -- s/serial/serial issue (?) -- It would be nice to add a note that this will also enable you to switch the itemtype of the last issue to another item type on receiving a new issue. Testing: - OK Adding subscription (syspref is OFF) -- System preference not active, only item type shows on form -- Item type is saved - Receiving issue and creating an item -- (3) In the item form, the selected itemtype doesn't preselect - OK Editing subscription -- Changes save correctly - Editing subscription (syspref is now ON) -- "Previous item type:" shows up now -- (4) I think the descrption might be misleading - as it's the final and not really the previous item type of the issue. Not sure I can explain that well. Maybe we could use a longer description? --- Item type for newest issue: / Item type for older issues: - OK receiving issues -- This is ok, as the last issue is set to my defined item type, but (3) is still showing as a problem here I have used numbers to mark some problematic bits. Please take a look! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
