http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603
Frédéric Demians <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #13 from Frédéric Demians <[email protected]> --- Thank you so much Jonathan for pushing to a better handling of print messages. Isn't there something that could be improve conceptually or from an architectural perspective? (always possible of course :-) On the one hand, there is C4::Letters module, and on the other hand process_message_queue.pl and gather_print_notices.pl using these module. Both .pl scripts are doing the same thing: gathering messages from the queue, and process them (send them, and switch there status from pending to sent or failed). For process_message_queue.pl, there is just one call to C4::Letter::SendQueuedMessages. When gather_print_notices.pl do all kind of processing, and then call C4::Letter internal function like _set_message_status. Shouldn't be logical just to merge both .pl scripts, and put all code in SendQueueMessage? SendQueueMessage interface could be extended with more parameters. For example: SendQueueMessage({ mtt => 'print', split => '0|1', dir => '/tmp', email_to => '[email protected]', format => 'html|csv', groupby => ['branch', 'letter'] }); -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
