http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941
--- Comment #12 from Jonathan Druart <[email protected]> --- (In reply to Frédéric Demians from comment #11) > (In reply to Jonathan Druart from comment #8) > > Comment on attachment 37734 [details] [review] [review] > > Bug 13941 [2/2] Fix <body> tags missing id/class > > > > Review of attachment 37734 [details] [review] [review]: > > Your points are well taken. You have good eyesight. > > But this: > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt > > @@ +19,4 @@ > > > > > > </head> > > > > > > +<body id="patlist_add_modify" class="pat patlist"> > > > > Shouldn't be patlist*s*? > > I don't understand. The module is plural, not the id (patron_lists vs patlist). See plugins and tools. But if you prefer patlist, go for it :) (In reply to Frédéric Demians from comment #10) > (In reply to Jonathan Druart from comment #7) > > Thanks for testing. > > > Comment on attachment 37735 [details] [review] [review] > > Bug 13941 [1/2] Test <body> tag with id/class attributes > > > > Review of attachment 37735 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: xt/tt_valid.t > > @@ +41,4 @@ > > > } > > > close $dh; > > > > > > +use YAML; > > > > Seems useless. > > Sure. > > > @@ +56,5 @@ > > > + { > > > + description => '<body> tag with id and class attributes', > > > + check => sub { > > > + my ($self, $name, $token) = @_; > > > + my $_ = $token->{_string}; > > > > Hum... Sure about this? :) > > Yes. Do you see anything wrong/strange? At least a warning :) Use of my $_ is experimental at xt/tt_valid.t line 61. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
