http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625
--- Comment #42 from Jonathan Druart <[email protected]> --- Comment on attachment 38277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277 Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips Review of attachment 38277: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11625&attachment=38277) ----------------------------------------------------------------- ::: tools/letter.pl @@ +85,5 @@ > + : $input->param('branchcode') ? > $input->param('branchcode') > + : $op ? > $input->param('branchcode') > + : GetBranchesCount() == 1 ? undef > + : > C4::Branch::mybranch(); > + Sorry but I am not confident enough with this part of code to pass qa on it today. This script is a house of cards and the branchcode variable is used at several place. You modify it at the beginning of the script, but it could introduce side effects. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
