http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13135

--- Comment #4 from M. Tompsett <[email protected]> ---
Comment on attachment 32619
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32619
Bug 13135 - cancel_expired_holds.pl/CancelExpiredReserves() logging
improvements to catch evasive bugs in production.

Review of attachment 32619:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13135&attachment=32619)
-----------------------------------------------------------------

::: Koha/Calendar.pm
@@ +365,5 @@
>  
> +sub printMe {
> +    my $self = shift;
> +    my @sb; #String buffer to collect self output.
> +    

Do you have your git configured properly? White space like this is bad.

git config --global core.whitespace trailing-space,space-before-tab
git config --global apply.whitespace fix

::: misc/cronjobs/holds/cancel_expired_holds.pl
@@ +17,4 @@
>  # with Koha; if not, write to the Free Software Foundation, Inc.,
>  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>  
> +use Modern::Perl;

Don't just change to Modern::Perl when both strict and warnings are commented
out. Are you sure this doesn't break anything else?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to