http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248
Jonathan Druart <jonathan.dru...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.dru...@biblibre.co
| |m
Status|Signed Off |Failed QA
--- Comment #6 from Jonathan Druart <jonathan.dru...@biblibre.com> ---
Martin,
Actually the 3 patches (from bug 14246 and 14247) could have been attached to
this bug report. No need to open 3 bug reports for 1 enh :)
I have some remarks concerning this patch:
1/ You add changes to a module file, in most of the cases, you have to provide
tests to make sure there won't be regression later.
Here you have to test C4::NewsChannels::get_opac_news, have a look at
t/db_dependent/NewsChannels.t
2/ A value for a pref can be retrieved directly from the template.
I would tend not to pass the display_news_author variable to the template, but
check/compare the syspref value in the template.
Since this is debatable, it's not blocker.
Marked as Failed QA for 1.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
