http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368
--- Comment #11 from Jonathan Druart <[email protected]> --- Comment on attachment 39182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39182 Bug 11368 - Add script to import Lexile scores Review of attachment 39182: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11368&attachment=39182) ----------------------------------------------------------------- I get this warning: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \%condition ) instead at misc/migration_tools/import_lexile.pl line 147 ::: misc/migration_tools/import_lexile.pl @@ +65,5 @@ > + 'source=s' => $subfield_source, > + 'source-value=s' => $subfield_source_value, > +); > + > +my $usage = << 'ENDUSAGE'; Should not we use Pod::Usage? @@ +82,5 @@ > + > +ENDUSAGE > + > +unless ($file) { > + say $usage; Prefer to call pod2usage. @@ +88,5 @@ > +} > + > +my $schema = Koha::Database->new()->schema(); > + > +my $csv = Text::CSV->new( { binary => 1, sep_char => "\t" } ) Shouldn't we use the pref "separator" and add an option to specify another one? @@ +121,5 @@ > + push( @isbns, $row->{$_} ); > + eval { push( @isbns, GetVariationsOfISBN( $row->{$_} ) ) }; > + } > + } > + @isbns = grep( $_, @isbns ); Not sure to undestand what this does :) @@ +142,5 @@ > + > + if ($verbose) { > + say "Found matching record! Biblionumber: $biblionumber"; > + > + if ( $verbose > 2 ) { You should mention this in the POD. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
