http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #38 from M. Tompsett <[email protected]> --- Comment on attachment 32683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32683 [SIGNED-OFF] Bug-6810: Send membership expiry reminder notices. Review of attachment 32683: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=32683) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +611,5 @@ > + Add_Delta_Days( @dateexpiry,0) > + ), > + 'iso' > + )->output(); > + } There is no better way to format $values->{'dateexpiry'} from SQL to whatever the system preference format string is?! This is ugly. There has got to be a better way. ::: C4/Members.pm @@ +1561,5 @@ > + SELECT borrowers.*, categories.description, > + branches.branchname, branches.branchemail FROM borrowers > + LEFT JOIN branches on borrowers.branchcode = branches.branchcode > + LEFT JOIN categories on borrowers.categorycode = > categories.categorycode > + WHERE dateexpiry = DATE_ADD(CURDATE(),INTERVAL $days DAY); Do the date math in Perl to avoid MySQLisms. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
