http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256

--- Comment #22 from Kyle M Hall <[email protected]> ---
Created attachment 40042
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40042&action=edit
[PASSED QA] Bug 14256: (follow-up) Check for unique constraint to regenerate
random data

There were some issues in the previous patch. This patch fixes the
following:
- rename $value with $original_value
- remove $at_least_one_constraint_failed and $values_ok which make the
  code unnecessarily complicated
- the constraints have to be checked only if no original value is passed
- _buildColumnValue created a key to the default value hashref, it broke
  the test:
    last BUILD_VALUE if exists( $default_value->{$source} );

Signed-off-by: Tomas Cohen Arazi <[email protected]>

Signed-off-by: Kyle M Hall <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to