http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001
Indranil Das Gupta <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39641|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta <[email protected]> --- Created attachment 40117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40117&action=edit Bug 14001: [DO NOT PUSH TO MASTER] Proof that the $_ is wrong. TEST PLAN --------- 1) create new branch based on master 2) apply this patch 3) make sure you have the barcode of something in your inventory. or add it accordingly. 4) Create a dummy barcode file with that barcode. 5) Home -> Tools -> Inventory/stocktaking 6) Browse for that file 7) Click the 'Compare barcodes list to results:' checkbox. 8) Click the 'Submit' button. 9) Check the koha error log. -- Errors being looked for are like: [Thu May 28 12:14:53.454702 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.454737 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.454757 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-28, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455013 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455033 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455052 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455345 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455366 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455384 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455539 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 278, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455539 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION: , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.455540 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION: 2015-05-25, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.458994 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: [Thu May 28 12:14:53 2015] inventory.pl: Use of uninitialized value in concatenation (.) or string at /home/mtompset/kohaclone/tools/inventory.pl line 325, <$fh> line 1., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.459018 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $_ VERSION (MOD): , referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl [Thu May 28 12:14:53.459037 2015] [cgi:error] [pid 2428] [client 192.168.45.37:52408] AH01215: $item VERSION (MOD): 2, referer: http://library-admin.debiankoha.ca/cgi-bin/koha/tools/inventory.pl As this should not be pushed to master, and is merely provided as evidence that there is a problem. Confirm that the two places correspond to the VERSION and VERSION (MOD) message locations. The test patch proves the error condition Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
