http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Jonathan Druart <[email protected]> --- It's much more better now! Still some minor issues: 1/ Could you try to add some style to the modal window? And create a label for the radio buttons. 2/ +use Modern::Perl; +use strict; +use warnings::register; => You don't need to use strict and warnings if you use Modern::Perl; 3/ Use POD to document your subroutines. 4/ Since the modal is only used from the detail page, why do you set the JS code in script.js and the modal code in masthead.inc? 5/ Choose a correct id for the modal div element (something better than myModal :)) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
