http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #2 from Indranil Das Gupta <[email protected]> --- Comment on attachment 40612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40612 Allow web-based self-checkout to be limited to only certain IPs or IP ranges Review of attachment 40612: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14407&attachment=40612) ----------------------------------------------------------------- I've not tested the code, but looking at the patch, here are my preliminary comments. ::: installer/data/mysql/atomicupdate/selfcheckallowbyiprange.sql @@ +1,1 @@ > +INSERT INTO systempreferences (variable,value,explanation,options,type) > VALUES two things here: 1/ you should probably consider re-naming the atomic update .sql filename - refer to http://wiki.koha-community.org/wiki/Database_updates#If_you_are_a_developer for file naming convention 2/ consider changing the syntax fro 'INSERT INTO' to 'INSERT IGNORE INTO' for compliance with Bug 9071. Otherwise this will likely result in "Failed QA" ::: installer/data/mysql/sysprefs.sql @@ +55,4 @@ > ('AutoSelfCheckAllowed','0','','For corporate and special libraries which > want web-based self-check available from any PC without the need for a manual > staff login. Most libraries will want to leave this turned off. If on, > requires self-check ID and password to be entered in AutoSelfCheckID and > AutoSelfCheckPass sysprefs.','YesNo'), > ('AutoSelfCheckID','','','Staff ID with circulation rights to be used for > automatic web-based self-check. Only applies if AutoSelfCheckAllowed syspref > is turned on.','free'), > ('AutoSelfCheckPass','','','Password to be used for automatic web-based > self-check. Only applies if AutoSelfCheckAllowed syspref is turned > on.','free'), > +('SelfCheckAllowByIPRanges','',NULL,('Leave blank if not used. Use ranges or > simple ip addresses separated by spaces, like <code>192.168.1.1 > 192.168.0.0/24</code>.)','Short'), The sysprefs are ordered alphabetically (and not necessarily grouped together by functionality). Please fix this, otherwise this will get stuck in QA. ::: opac/sco/sco-main.pl @@ +36,4 @@ > > use CGI qw ( -utf8 ); > use Digest::MD5 qw(md5_base64); > +use Net::IP::Match::XS; you are introducing a new perl dep. from my preliminary look, this module is probably not packaged for Debian / Ubuntu. If that is the case, then until it is packaged as .deb (upstream in the distros or by someone here or by Robin Sheat (provided he has the time and inclination to package it), this patch won't make it to a release. Just an FYI. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
