http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7140
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #7 from M. de Rooy <[email protected]> 2011-11-30 13:20:50 UTC --- Thanks for responding and providing more info. You are right about the double itemtype. It is not related to your patch; it is just a strange thing on several places in Koha to show it twice if noItemTypeImages is set or the imageurl is empty. In my opinion listing it twice is just a bug. But that is another bug report. I would like to add to your comment that results depend on the value of pref item-level_itypes. I have two points on your patch now: Search Results: if item-level_itypes==item, then the itemtype (+icon) is already in the column Location (per item) if item-level_itypes==biblio, then the itemtype (+icon) is already in the column Results my conclusion would be: itemtype is not needed additionally here (redundant) Catalogue Details/Items tab: if item-level_itypes==biblio, then the item type is listed with the biblio on top if item-level_itypes==item, then the item type is listed per item Your patch apparently does not really change anything here. (But it would catch the situation mentioned above!) It merely rearranges the tests on noItemTypeImages and imageurl. Looking further, I think that the moredetail script (for the Items tab) should fill imageurl for items, but it does not. The template uses that empty variable! So it never shows an icon. If you change the code here, please resolve that bug too. After those two points, I am wondering if the changes in Search.pm are necessary. Did not further look into that. Could you explain why they are necessary? I agree with you that this is a lot of text for a small patch ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
