http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250
--- Comment #4 from M. Tompsett <[email protected]> --- Comment on attachment 40759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40759 Bug 11250 - "too many holds" message appears inappropriately Review of attachment 40759: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11250&attachment=40759) ----------------------------------------------------------------- Though I like the shift to the IF/ELSIF structure, I'm not sure it addresses the first two comments. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +309,5 @@ > + <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% > borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> > <strong>already has a hold</strong> on this item </li> > + [% ELSIF ( ageRestricted ) %] > + <li><strong>Age restricted</strong></li> > + [% ELSIF ( none_available ) %] > + <li> <strong>No items are available</strong> to be placed on > hold</li> There is a difference between none_available (but eventually some may) vs. comment #2's "{item} is not allowed to be placed on hold". Is there a way to check for this? @@ +311,5 @@ > + <li><strong>Age restricted</strong></li> > + [% ELSIF ( none_available ) %] > + <li> <strong>No items are available</strong> to be placed on > hold</li> > + [% ELSIF ( maxreserves ) %] > + <li><strong>Too many holds: </strong> <a > href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber > %]">[% borrowerfirstname %] [% borrowersurname %] </a> has too many > holds.</li> Similarly there is a minor difference between a borrower who has too many holds (non-zero), and one who isn't allowed to place any at all, as per my understanding of comment #1. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
