http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375
Olli-Antti Kivilahti <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #11 from Olli-Antti Kivilahti <[email protected]> --- Hi there! I like your approach, you are doing the right thing. DBIx::Connector is said to be more robust and I am happy to hear it has solved your issues. However there is an issue with this patch that needs addressing if you want a sign off from me. First of all the naming convention is changed which can cause a lot of issues for everybody. Some tests, custom modifications etc. can depend on $context->{dbh}. The new name doesn't help increase clarity IMHO and we should stick to the old "dbh". - return $context->{"dbh"}; + return $context->{'DBconn'}->dbh; Same issue here -sub _new_dbh +sub _new_DBconn _new_dbh is addressed directly from many places (atleast I do) regardless of it being a private method. This is to circumvent bugs/limitations of the C4::Context->dbh()-system. No reason to change it. Because of these things a small and beautiful, yet invaluably important fix is drowned into a large commit changing too many things for reasons I do not agree of. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
