http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Kyle M Hall <[email protected]> --- (In reply to Jonathan Druart from comment #6) > Comment on attachment 41170 [details] [review] > [SIGNED-OFF] Bug 14597 - Reverting a batch where a record overlaid is now > deleted record will fail > > Review of attachment 41170 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/ImportBatch.pm > @@ +813,4 @@ > > sub BatchRevertRecords { > > my $batch_id = shift; > > > > + my $logger = Koha::Logger->get( { category => > > 'C4.ImportBatch.BatchRevertRecords' } ); > > Really? > We are going to create an instance of Log::Log4perl for each subroutine call? Yes, otherwise we cannot do the namespacing as far as I know. This is intrinsic with Log4Perl and not a limitation of Koha::Logger. Without namespacing we may was well stick to using warn() -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
