http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy <[email protected]> 2011-12-05 09:43:16 UTC --- QA Comment: I did not test this patch, but have some comments on the code that is not directly touched by this patch but is in the direct context. I think that the check if ($ip !~ /^$domain/) does not work. If domain is a full IP address it works. But if domain is a subnet mask like 199.1.*, the check will also approve addresses like 199.11.12.13 which it should not (.* will `eat` 1.12.13). >From a QA standpoint, I do not like it that the code here takes its regex here directly from the database. The point in the database column is not meant as a regex wildcard. My recommendation therefore is that this patch should also correct this regex, since it directly deals with the if-condition on top of it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
