http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ommunity.org Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <[email protected]> --- (In reply to Galen Charlton from comment #5) > Comment on attachment 24754 [details] [review] > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal > > Review of attachment 24754 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/opac-account-pay-paypal-return.pl > @@ +20,5 @@ > > + > > +use strict; > > +use warnings; > > +use utf8; > > + > Modern::Perl > I see no non-ASCII characters in the source. Still exists. > ::: opac/opac-account-pay.pl > @@ +19,5 @@ > > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > + > > +use strict; > > +use warnings; > > +use utf8; > Modern::Perl > I see no non-ASCII characters in the source. Still exists. > @@ +94,5 @@ > > + 'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale', > > + 'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly', > > + 'PAYMENTREQUEST_0_DESC' => > > + C4::Context->preference('PayPalChargeDescription'), > > + }; > > It seems like using Business::PayPal::API might offer some protection > against API changes. Answer needed. +use CGI; Should be replaced by CGI qw( -utf8 ) unless you have a good reason. > 3) Create a paypal developer account How? Should I need a paypal account to do so? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
