http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #14 from Genevieve Plantin <genevieve.plan...@inlibro.com> --- Created attachment 42470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42470&action=edit Bug 12446 - Clean code according to Comment 12 For the first recommendation, I tried to be more explicit, I don't know if you would prefer it because it is slower. For the second point, I've got rid of the UPDATE line so we don't activate a new functionnality. For the third point, I was told that the coma was there in case of new addition. Fourth, I corrected the mistake. For the fifth recommendation, I tried to separate the hardcode categories, but it is simple for the display (it only changes a the choice in the select for yes, but the user can still change it aftewards). However, I modified it so, if someone wants to add a new category to be displayed as guarantee by default, he only has to add the category code in the array instead of writting another select == 'new category'. For the sixth point, I replaced the space. Lastly, I deleted these lines because, as you said it, it wasn't used. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
