http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|[email protected] |[email protected] |y.org | --- Comment #22 from Marcel de Rooy <[email protected]> --- QA Comment: I am taking the liberty to pass qa on this report. Since Indranil signed off on both patches, I gain my QA token again.. Works as described. QA tests pass. The feature is kind of undocumented now. It should be described somewhere (help page, manual, on the form??) The code in Letters.pm is already less maintainable and this fix will not improve the situation. But it is a global solution and it is in written in a way that could[..] be extended with similar filters. The three added tests are testing the same thing. Seems to be overkill. I could better understand your testing the same report with dateonly flag and without it to show the difference. But no big deal. Passed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
