http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426
--- Comment #26 from Jonathan Druart <[email protected]> --- Comment on attachment 42618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42618 Bug 12426: Allow resend for sent messages Review of attachment 42618: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12426&attachment=42618) ----------------------------------------------------------------- + Your patch introduces trailing whitespaces. ::: members/notices.pl @@ +58,5 @@ > my $message = C4::Letters::GetMessage( $message_id ); > if ( $message->{borrowernumber} = $borrowernumber ) { > C4::Letters::ResendMessage( $message_id ); > + # redirect to self to avoid form submission on refresh > + print > $input->redirect("/cgi-bin/koha/members/notices.pl?borrowernumber=$borrowernumber"); Not sure this is useful, what will happen if the form is resubmit? That will change the status from pending to pending? :) ::: t/db_dependent/Letters.t @@ +18,4 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; > +use Test::More tests => 68; I'd say we can keep the test you have removed, and adapt it. So we check a message can be resend independently of its status. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
