http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3385

Paul Poulain <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |rel_3_6
       Patch Status|Signed Off                  |Patch Pushed

--- Comment #8 from Paul Poulain <[email protected]> 2011-12-06 
18:22:52 UTC ---
QA comment:

the following construct:
+    $item->{$_}                        = format_date( $item->{$_} ) foreach
qw/datelastborrowed dateaccessioned datelastseen lastreneweddate/;

is not PBP friendly.
It's recommended to write 
foreach {
    bla
}

perlcritic says it's a level 2 severity:
Postfix control "foreach" used at line 131, column 69.  See page 96 of PBP. 
(Severity: 2)

We want to be level 5, so passed QA

Patch pushed, please test

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to