http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ommunity.org --- Comment #5 from Jonathan Druart <[email protected]> --- Marc, This is not the way to go, for several reasons. The main reason is that you c/p dt_from_string to create the new subroutine, which is bad. Then, if you have a look at dt_from_string, you will note 1 eval around the first DateTime->new (l. 156), but not around the second one (l. 164). So I think there are at least 2 better ways to know if a date is not correctly formatted: 1/ add an eval around the second DateTime->new call, the subroutine will return undef and the caller will have to check if something has been returned ; 2/ or catch the croak raised by the DateTime in the callers I don't know what I would prefer (a bit early and not drank enough tea yet). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
