http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
--- Comment #46 from Jonathan Druart <[email protected]> --- (In reply to Charles Farmer from comment #45) > (In reply to Jonathan Druart from comment #38) > > It does not seem to work if item-level_itypes is set to biblio. > > You should also provide tests for C4::Circulation::LostItem (I suspect that > > the problem comes from the query executed in this subroutine). > > When you say "provide tests for LostItem", do you mean that a separate file > should be written under t/db_dependent/Circulation/ for that purpose, or > would you accept if the tests were added to everything else in Circulation.t > ? The last patch could do the job, if the itemtype type you used (BK) was created (tests should create their own data). But thinking about it, I am wondering why you pass the processfee to chargelostitem and don't retrieve it in the chargelostitem subroutine. It also a bit weird to pass an issue, the name of the sub is chargelost*item* :) Kyle, could I get your opinion on that please? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
