http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <[email protected]> --- Hi Matthias, I've taken a look at the code and the GUI, but there are some small and some bigger things bothering me: 1) Display of patron names (trivial) + .append( "<a>" + item.surname + ", " + item.firstname + ", " + item.branch + "</a>" ) Please also think about the case where the patron has no firstname (organisations for example) 2) Logging + my $member = GetMember(borrowernumber => $$suggestion_only{'suggestedby'}); + logaction('ACQUISITIONS', 'MODIFY', undef, 'Suggestion title: ' . $$suggestion_only{'title'} . ", creator: " . + $member->{'surname'} . ', ' . + $member->{'firstname'} . ' (' . + $member->{'cardnumber'} . ')' ); a) I think we need to make more clear about which action in acquisitions this entry is about. I'd suggest to either add a new module 'SUGGESTIONS' or to be more clear about the action: 'MODIFY SUGG' or similar. b) For privacy reasons I am also quite uncomfortable about adding the name in plain text to the logs. We don't need this information if we reference the borrowernumber instead and it will also be better for privacy. For me this is a (blocker). c) Why are you leaving the object undef? I feel like this should be the suggestion id. Then we could just have the borrowernumber in the description. All other information can easily be found. d) I think the new logging needs to be covered by a system preference to be consistent with current practice. -- Don't misunderstand me - I really think we should do more nice logging! But I think we should try to avoid some of the problems we had with it in the past. One idea might even be to add a new column to action_logs to be able to store another id in a better way (user, object, affected_user?) 3) GUI I'd prefer the way patron search is done in other places taking place in a separate pop-up or modal. Because it offers a better overview for libraries with a lot of patrons and better options to limit search. An example would be the way it's done for searching patrons to be notified about an order (when creating an order line). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
