http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504
--- Comment #18 from Jonathan Druart <[email protected]> --- (In reply to Kyle M Hall from comment #17) > (In reply to Jonathan Druart from comment #16) > > Barton, have you seen my suggestion on comment 12? > > I think it will be really easy to implement what you want using it (no > > change in pm and no additional tests). > > While your suggestions would definitely work, I think what Barton's changes > are a good and worthwhile improvement. The logic to for deciding if an item > is deletable should definitely be separate from the actual deleting of > items, and now we've got more through unit tests as well! Yes maybe you are right but we are adding 1 new subroutine and lot of code when the 2 start_transaction/rollback lines would make the job. Anyway, if you really want this way, I have still some concerns: 1/ Tests should create their own data (branchcode/categorycode), it is easier to use TestBuilder for that. 2/ I don't think a subroutine should take a do_not_commit parameter, this should not do it in the subroutine but from the scripts. Keeping the signed off status to get feedback from other QAers. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
