http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7157

Paul Poulain <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
       Patch Status|Passed QA                   |Failed QA

--- Comment #5 from Paul Poulain <[email protected]> 2011-12-12 
14:47:44 UTC ---
A small problem not noticed by Marcel or Chris: the syntax of the parameters:
http://search.cpan.org/~jv/Getopt-Long-2.38/lib/Getopt/Long.pm

=> 1 character parameters are called with a single -, others are with --

the -man means in fact -m -a -n
the -help means -h -e -l -p

You should have written --help and --man
Your script is working, but:
* a new option/parameter may result in strange results that will be hard to
understand
* cronjob scripts are with -- for long options

So, please resubmit your patch with help=s and updated documentation

(great script though !)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to