http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
--- Comment #2 from David Cook <[email protected]> --- Comment on attachment 41642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642 Bug 14367: Add MARC record history Review of attachment 41642: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14367&attachment=41642) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +3531,4 @@ > sub ModBiblioMarc { > # pass the MARC::Record to this function, and it will create the records > in > # the marc field > + my ( $record, $history, $biblionumber, $frameworkcode ) = @_; Why would you add $history as a 2nd positional parameter here? Wouldn't it make more sense to add it as the 4th, so that you wouldn't affect any existing calls to ModBiblioMarc that don't require the history? I notice $history was added as the last positional parameter on other functions which use history, so doing that here would be more consistent as well... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
