http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154
--- Comment #11 from Eivin Giske Skaaren <[email protected]> --- (In reply to Katrin Fischer from comment #9) > We should fix these reports sometime... but I am ok with 'not right now' :) > > I will attach a patch with some tiny follow-ups to the terminology used, can > you please take a look? > > Also a question, why these commented out lines? > + # These limits does not currently exist, maybe later? > + # $colfilter[0] = @$filters[6] if ($column =~ /ccode/ ) ; > + # $colfilter[0] = @$filters[7] if ($column =~ /location/ ) ; > + $colfilter[0] = @$filters[8] if ($column =~ /category/ ) ; > + # This commented out row (sort2) was not removed when adding new > filters for ccode, shelving location and call number I will take a look at the QA follow up tonight. For the commented out lines there were 2 considerations: 1. One already commented out line that seemed out of place but I did not remove it. 2. Fill in gaps just to make the magic numbers less confusing. It is easy to overlook a missing row etc in this type of code. I can remove the commented out code if that is preferred. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
