http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006
--- Comment #3 from Colin Campbell <[email protected]> --- (In reply to Frédéric Demians from comment #2) > With this: > > my $timeout = $self->{service}->{client_timeout} || > $config->{client_timeout}; > > what will happen after Koha upgrade if a library doesn't add the new > 'client_timeout' parameter to its config file. Wouldn't it be better to have > something like: > > my $timeout = $self->{service}->{client_timeout} || > $config->{client_timeout} || > $self->{service}->{timeout} || $config->{timeout}; > > And/or a note via updatabase.pl to notify that SIP config file has to be > reviewed after upgrade. If the client_timeout is not present the current situation remains the same (or in fact reverts to the situation before timeout was incorrectrly extended to timeout active connections) Your suggestions for adding it to the test preserves the bad code from patch 13432 which has caused in my experience to make previously working installs go unstable. Once this gives a working system, I'm hoping to overhaul the cxonfig file which is under documented -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
