http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.dru...@bugs.koha-c
| |ommunity.org,
| |m.de.r...@rijksmuseum.nl,
| |martin.renvoize@ptfs-europe
| |.com
Status|Signed Off |Failed QA
--- Comment #31 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
---
QA comments:
This is a very simple implementation, but could be considered as a first step.
I would like to get feedback from someone else (ccing some QA people).
For instance 1. there is no way to sent an sms instead of an email, 2. the
letter is generated even if the patron does not have an email address defined,
3. there is no way to know if a recall has already been generated
I don't understand the use case, why don't you use the overdue_notices script
instead?
Technical review:
1/ A variable items_checked_out is passed to the template but never used.
2/ ajax script should be moved to the svc/ directory
3/ The Recall button is display if the pref is set, then the user get an
unauthorised message if does not have the permission.
It would be easier not to display the button in this case... (and sent a 403 if
the script is called).
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
