http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633
Magnus Enger <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #35 from Magnus Enger <[email protected]> 2011-12-30 11:26:01 UTC --- I applied all the patches attached, in the order they are listed, so git log gives me this: $ git log --pretty=oneline --abbrev-commit 23c90fb Bug 1633 - Interface revisions for the staff client 6a652ec Bug 1633: Don't show image tab when inappropriate 7abbc66 Bug 1633 - Add ability to take book cover images from local img db 57eda8a Bug 1633: Display local cover images 38762dd Bug 1633: Add support for uploading images to Koha f99601e Bug 7375 - Update minimum version of Perl to 5.10 I'm marking this failed QA because of the following three blockers. The enhancements would be nice to have, but can be left for later. *** Blockers * No image shown when there is just one LocalCoverImages = On Uploaded one image and attached it to biblionumber = 1. Image shows OK here: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1 But: "There are no images for this record." at /cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=1&imagenumber=1 Changing line 68 of koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt from this: [% IF ( images.size > 1 ) %] to this: [% IF ( images.size > 0 ) %] makes the image display. Uploading a second image makes both of them display correctly. * AllowMultipleCovers does not stop multiple covers With AllowMultipleCovers = "Don't", /cgi-bin/koha/tools/upload-cover-image.pl was automatically set to "Replace existing covers", but I had no problem adding multiple covers to one record. * Always "Click on an image..." On records that have no associated images I always see this: "Click on an image to view it in the image viewer", not this: "No images have been uploaded for this bibliographic record yet. Please upload one.". Changing line 522 in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt from [% IF ( localimages ) %] to [% IF ( localimages.0 ) %] seems to solve this. I'm not sure, but I think that when there are no images, localimages is an array where the first element is undef, not an array that is undefined - or something like that... *** Enhancements * How can images be deleted? * Thumbnails have empty alt Thumbnails displayed on the right hand side in the image viewer (both OPAC and Intranet) have empty alt attributes: <img alt="" src="/cgi-bin/koha/catalogue/image.pl?imagenumber=3&thumbnail=1" id="3" class="thumbnail"> It could perhaps say alt="Thumbnail" or something similar? * Still possible to see images when OPACLocalCoverImages is off OPACLocalCoverImages = Don't display I can still see the image at /cgi-bin/koha/opac-image.pl?imagenumber=1 * Wrong POD in tools/upload-cover-image.pl? The POD on line 33 of tools/upload-cover-image.pl says: "Files greater than 100K will be refused. Images should be 140x200 pixels. If they are larger they will be auto-resized to comply." I was able to upload an image of 1.3MB without any trouble, and it was resized correctly. The last part of this has perhaps not been updated to take into account the 600x800 pixel max size of the "large" view? * Images in the modification log? When I look at /cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=1 there is no mention of the images there. Perhaps that would be a nice addition, so you could see when images were added, removed etc? * Make it possible to select "main" image when there is more than one Looks like the first image to be uploaded is the one that is displayed in the result list and at the top of a record in detail view. Might be nice if it was possible to select which image should be the "main" one. * Make it possible to replace one specific image among several -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
