http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

--- Comment #31 from Jonathan Druart <[email protected]> 
---
QA comments:

1/ The correct mimetype for json is application/json
(https://www.ietf.org/rfc/rfc4627.txt).
Maybe it would be easier to use C4::Output::output_with_http_headers

2/
+if ( $auth_status ne "ok" ) {
+    exit 0;
+}

It might make more sense to return a 403.

3/ I am a bit worried to add different ways to suspend/resume hold, the others
(in C4::Reserves) are mainly used and the behaviors could differ. Does the plan
is to adapt the existing code to use these new methods?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to