https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635
--- Comment #7 from Jonathan Druart <[email protected]> --- (In reply to M. Tompsett from comment #5) > Comment on attachment 47125 [details] [review] > Bug 15635: Koha::Patron::Images - Remove RmPatronImage > > Review of attachment 47125 [details] [review]: > ----------------------------------------------------------------- > > ::: tools/picture-upload.pl > @@ +163,5 @@ > > + my $deleted = eval { > > + Koha::Patron::Images->find( $borrowernumber )->delete; > > + }; > > + if ( $@ or not $deleted ) { > > + warn "Image for patron '$borrowernumber' has not been deleted"; > > Should we not distinguish between $@ and not $deleted? It's what I did for other admin scripts, we could display the error ($@) if needed but could be done later. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
