https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795
M. Tompsett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from M. Tompsett <[email protected]> --- I made it apply, but Bernardo Gonzalez Kriegel raises a valid problem in comment #5. $ git grep associatedborrower -- There is mention of it in installer/data/mysql/backfill_statistics.pl Is this script used at all? Obviously people aren't going to need it after upgrading from 2.x to 3.x versions. Perhaps safe to remove? Perhaps backfill_statistics.pl needs a rewrite? other is used in C4::Circulation::AddIssue related to SIP mode. In C4/Accounts.pm and C4/Circulation.pm (only places to use UpdateStats), the following fields are used: branch type amount other itemnumber itemtype borrowernumber ccode accountno schema says that usercode and associatedborrower is unused. Looking at C4/Stats.pm it becomes painfully clear (painful, because they shouldn't have renamed the field like that) that accountno is proccode. I wonder if people are expecting it to be longer than varchar(4). I would resubmit this modified with: 1) Just usercode and associatedborrower removed 2) an atomic update instead of a updatedatabase.pl (https://wiki.koha-community.org/wiki/Database_updates) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
