https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Jonathan Druart <[email protected]> --- My cellular provider does not provide this service, I am not able to test that the whole workflow works correctly. A few feedbacks anyway: 1/ It would be great to provide a Koha::Objects implementation for Koha::SMS::Provider 2/ SMSSendDriver is passed to the template in admin-home.pl, it's not necessary (use TT plugin instead) 3/ sms_providers.pl: use strict;use warnings; => use Modern::Perl; 4/ the ENGINE for the new table is not correct in the atomic update entry. 5/ You are create an index on a FK, it's not necessary: https://dev.mysql.com/doc/refman/5.7/en/create-table-foreign-keys.html Search for "Such an index is created on the referencing table automatically if it does not exist." 6/ When editing a patron, should not we hide the "sms provider" part if the sms number is not filled? 7/ When editing a provider, the selected line has a red background. We have the same behavior on smart-rules.pl and the background use is orange. It would make sense to have the same color. Marked as Failed QA for 2, 3, 4, 5 and 7 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
