https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777
Bug ID: 15777
Summary: Refactor loop in which Record::Processor does not
initialize parameters
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
foreach my $filter (@{ $req_filters }) {
next unless $filter;
my $filter_module = $filter =~ m/:/ ? $filter :
"Koha::Filter::${schema}::${filter}";
if (can_load( modules => { $filter_module => undef } )) {
my $object = $filter_module->new();
$filter_module->initialize($param);
push @filters, $object;
}
}
"$filter_module->initialize($param);" should be
"$object->initialize($param);
Additionally, object isn't really descriptive, and it isn't clear that $filter
is the string name of the filter. So, this loop will have some variable
renaming done on it.
And the first commit will include a test that fails to initialize.
And the second commit will include this revision which should then pass.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
