http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5503
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Failed QA --- Comment #9 from Paul Poulain <[email protected]> 2012-01-10 22:23:45 UTC --- QA comment Well, it seems this patch has not be tested. When upgrading, I get a mySQL error: [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4610. [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4611. Looking at the code, I see : $dbh->do(" UPDATE `koha`.`systempreferences` SET `value` = 'none', `options` = 'none|full|first|surname|firstandinitial|username', `explanation` = 'Choose how a commenter\'s identity is presented alongside comments in the OPAC', `type` = 'Choice' WHERE `systempreferences`.`variable` = 'ShowReviewer' AND `systempreferences`.`variable` = 0"); Should be commenter''s I think. Also note, as you'll have to send a follow-up that ` should be removed from table & column names, it's a mysql-ism thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
