https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #48 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
Since this patch waited much too long, I have been working somewhat more on it
to get it thru QA.
My main concerns were:
[1] Change of behavior when sending correct card number but invalid password.
We should get patron info with BL=Y and CQ=N.
Your patch changed the if-structure and handled this situation similar to wrong
card number. So no patron information.
Handled in a followup.
[2] Adding a SIPconfig attribute like overdrivemode or msg_invalid_credentials
is not really needed. If we can prevent adding such "prefs", the code will be
simpler.
Although the response contains BL and CQ to inform about the checked
credentials, we could just send "Invalid card number" if there is no card (add
AF here).
If the card is OK and the pw is not, we could add Invalid pw to the existing
AF. This does not harm anyone.
Handled in a followup.
[3] We should have a look at Patron Info too. Added a followup.
Added a new report for additional unit tests for changes in Patron
Status/Patron Info.
Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
