https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48633|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
Created attachment 48676
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48676&action=edit
Bug 15968: Unnecessary loop in C4::Templates
From C4::Templates::output
# add variables set via param to $vars for processing
for my $k ( keys %{ $self->{VARS} } ) {
$vars->{$k} = $self->{VARS}->{$k};
}
This loop is not necessary, we could do the same with
$vars = { %$vars, %{ $self->{VARS} } };
After a quick benchmark, it gains 100 microseconds when we pass 170 vars
to the template.
Test plan:
Do some clicks on the interface, everything should be ok.
Signed-off-by: Frédéric Demians <f.demi...@tamil.fr>
Perl idiosyncratic way of merging hash, clearer, if not quicker (not
verified)
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
