http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5347

--- Comment #49 from Paul Poulain <[email protected]> 2012-01-13 
15:12:10 UTC ---
QA comments:
1 what's the use of div.info in staff.css ? couldn't we use an existing class ?
2 there is a new sub in C4/Acquisitions.pm (AddClaim), but no unit test. I've
already pushed a patch with a new sub here and no unit test, so I won't refuse
this one, but that would be a plus.
* Other than this = good code, fixes some crapy things in previously existing
code, perlcritic OK, except for C4/Letter.pm that was not perlcritic-compliant
before the patch, so no regression here

not marking passed QA because or point 1 & 2

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to